search

concretecms / concrete5-legacy

Legacy repository for concrete5
http://www.concrete5.org
559 stars 323 forks source link

Fixed bug where format drop down list wouldn't show the currently active format for a parent element #1943

Closed jordanlev closed 8 years ago

jordanlev commented 8 years ago

Fixes this issue: https://www.concrete5.org/developers/bugs/5-6-3-4/tinymce-format-dropdown-not-showing-selection-format by applying this change from an old TinyMCE version: https://github.com/tinymce/tinymce/commit/b50e7199cc49a4f4164e0f0d5790c93d691e1f71

jordanlev commented 8 years ago

Hi @Remo , Someone on the C5 bug report thread pointed out that this fix doesn't only applies to the "Custom" Toolbar Set (in "Rich Text Editor" dashboard page).

I am not sure how the TinyMCE javascript is supposed to get built for C5 releases -- do you have any advice for me?

  1. How are the various "theme" editor_template_src.js files compiled/minified down to the editor_template.js files? If I know this, I can apply the fix to the "Advanced" theme.
  2. For the "Office" theme, I don't see where that theme directory is located in the filesystem (I only see /advanced, /concrete, and /simple directories within /concrete/js/tiny_mce/themes/)
  3. For the "Simple" theme, I cannot find the string DOM.isblock in /concrete/js/tiny_mce/themes/simple/editor_template_src.js , which means I don't know how to apply this fix to that theme. Hence I think we may not be able to apply the fix for the Simple theme (unless someone else can figure out what is causing the problem there).

Thanks.

Remo commented 8 years ago

@jordanlev we used to do that before a release because you create a lot of merge conflicts if you run such scripts on multiple pull requests. I realize that this might not be the best approach anymore as we don't have a lot of changes here. The build instructions can be found here, it's a simple grunt file https://github.com/concrete5/concrete5-legacy/tree/master/build I'm not sure it will do everything you're looking for, if I remember correctly we have some redundancy there, not sure though.