concretecms / concrete5-legacy

Legacy repository for concrete5
http://www.concrete5.org
559 stars 323 forks source link

Option to specify google map key #1954

Closed Remo closed 6 months ago

Remo commented 7 years ago

I'm not sure I'm going to merge this as it is. I find it a bit ugly to have a field in a block which is saved globally, but I don't see a point to have it block specific. I'll try to reserve some time later and maybe create a single page for this.

JohntheFish commented 7 years ago

I don't see any problem with editing a global setting in a block edit dialog, as long as its made clear it is global across all maps blocks. Having it in the block edit dialog is in many ways quicker to set up without having to hop from the maps block to the dashboard and back.