search

concretecms / concrete5-legacy

Legacy repository for concrete5
http://www.concrete5.org
559 stars 323 forks source link

Change continue to break in custom_style.php #2005

Closed JohntheFish closed 3 years ago

JohntheFish commented 3 years ago

The continue statements within a switch throw warnings that prevent custom styles from being used. In this context a break statement achieves the same purpose.

Remo commented 3 years ago

@JohntheFish I can merge this, but I don't have an environment to test it. Did someone else test this? Are you certain this only improves things?

JohntheFish commented 3 years ago

It worked for me, but it would be best to have an independant test. My main motivation was preventing an error rather than using the functionality, so I have not tested particularly thoroughly beyond that.

There are others doing a lot more with legacy code than I am, so perhaps leave it for a few weeks and see if someone else can confirm with an independant test.

Remo commented 3 years ago

Okay, I'll leave it open till I get some feedback.

mlocati commented 3 years ago

My PC is a few thousand kilometers away from me ATM, but I don't see any reason why this change could break something: https://3v4l.org/70OuQ

Remo commented 3 years ago

Okay, since there's nothing else in the loop this should be good to be merged. Thanks @mlocati and please go and enjoy the view from Faros Taverna now 😄