search

concretecms / concretecms

Official repository for Concrete CMS development
https://www.concretecms.org
MIT License
776 stars 454 forks source link

RSS Feed Error #12051

Open pvernaglia opened 6 months ago

pvernaglia commented 6 months ago

Affected Version of Concrete CMS

9.x

Description

Hi, I'm upgrading a v8 site to 9.2.8, there is an RSS block pulling in from https://www.nimh.nih.gov/site-info/index-rss.atom?format=xml, it's working fine on v8 but on v9 I am getting an error:

Argument 1 passed to Concrete\Core\Feed\FeedService::getPosts() must be an instance of Laminas\Feed\Reader\Feed\Rss, instance of Laminas\Feed\Reader\Feed\Atom given, called in /home/gztqnasb/public_html/concrete/blocks/rss_displayer/controller.php on line 193

I'm able to duplicate on a clean install of 9.2.7 as well

How to reproduce

Installing the RSS block on a page in V9.2.8 or 9.2.7, I'm using https://www.nimh.nih.gov/site-info/index-rss.atom?format=xml page crashes with error message above.

Possible Solution

No response

Additional Context

No response

aembler commented 6 months ago

Since this requires some light tweaks to the FeedService class, we'll want to wait until 9.3, but this should be as simple as changing the Rss typehint to FeedService.