search

concretecms / concretecms

Official repository for Concrete CMS development
https://www.concretecms.org
MIT License
772 stars 453 forks source link

Make more information avaliable to on_start function #3676

Closed Ruudt closed 4 years ago

Ruudt commented 8 years ago

To make the PageController on_start function the central starting point for my class logic I'd like to know what the current request is exactly. Unfortunately on_start() is ran 1 line before setupRequestActionAndParameters().

Current situation: image https://github.com/concrete5/concrete5/blob/develop/web/concrete/src/Routing/DispatcherRouteCallback.php#L194

Is there any reason not switch the two lines?

Mnkras commented 8 years ago

Previously I basically just re-created the request object like the core does, I don't see a downside really, besides the fact that we might to a little extra processing when we don't have to.

aembler commented 8 years ago

I don't think there's any reason not to switch those lines.

On Mon, Apr 11, 2016 at 9:25 AM, Michael Krasnow notifications@github.com wrote:

Previously I basically just re-created the request object like the core does, I don't see a downside really, besides the fact that we might to a little extra processing when we don't have to.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/concrete5/concrete5/issues/3676#issuecomment-208434146

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!