concurrencykit / ck

Concurrency primitives, safe memory reclamation mechanisms and non-blocking (including lock-free) data structures designed to aid in the research, design and implementation of high performance concurrent systems developed in C99+.
http://concurrencykit.org/
Other
2.35k stars 312 forks source link

ck_ec and ck_hs tests dump core on FreeBSD #138

Closed lwhsu closed 5 years ago

lwhsu commented 5 years ago

ck_ec and ck_hs tests dump core on FreeBSD. Tested on FreeBSD amd64 12.0-RELEASE and -CURRENT.

While ck_ec seems not supporting FreeBSD at this moment, but these tests would be better to just exit on OSX instead of dumping core.

sbahra commented 5 years ago

We'll update ck_ec to work on FreeBSD. Could you share logs and more details of these failures? Output of make check would be useful as well as any accompanied backtraces.

cognet commented 5 years ago

I'll have a look at FreeBSD issues

sbahra commented 5 years ago

ck_ec has not been tested on FreeBSD, but as it's mostly freestanding (and tested on both clang and gcc), there isn't a good reason we don't add umutex coverage as well.

ck_hs has been fixed, this was an invalid test that was introduced with ck_hs_next_spmc a while ago.

Worth adding valgrind and ASAN to our tests.

sbahra commented 5 years ago

ck_ec is fixed now as well, underlying root cause was GNU makeism for the tests. Thanks for reporting!