search

concurrencykit / ck

Concurrency primitives, safe memory reclamation mechanisms and non-blocking (including lock-free) data structures designed to aid in the research, design and implementation of high performance concurrent systems developed in C99+.
http://concurrencykit.org/
Other
2.34k stars 312 forks source link

build: Use ilp32d abi on riscv32 #204

Closed kraj closed 1 year ago

kraj commented 1 year ago

ilp32d is common ABI used for linux distributions therefore a better default

Signed-off-by: Khem Raj raj.khem@gmail.com

cognet commented 1 year ago

Hi @kraj,

What do you think of just not forcing the ABI here, and either using the compiler default, or letting people choose it at configure time ?

kraj commented 1 year ago

Hi @kraj,

What do you think of just not forcing the ABI here, and either using the compiler default, or letting people choose it at configure time ?

yeah I would say thats a better approach. Since that means it wont need such overrides. However, if you want to choose default then lp64d is the right default as its most commonly used ABI

cognet commented 1 year ago

@kraj I understand, I'll just get it removed, I don't think we should force an ABI, anyway. Thank you!

cognet commented 1 year ago

Closing the PR, there is no longer any ABI forced