concurrencylabs / aws-cost-analysis

Tools that make it easier to analyze AWS Cost and Usage reports. Initial version provides support for Athena and QuickSight.
GNU General Public License v3.0
173 stars 43 forks source link

Update the CloudFormation template with the rest of the resources #7

Closed Nr18 closed 6 years ago

Nr18 commented 6 years ago
Nr18 commented 6 years ago

Noticed that the creation of the Athena table still resulted in a failure fixed it by applying the correct paths

concurrencylabs commented 6 years ago

Thanks for all the improvements, just to let you know we're still reviewing. We need to make sure our running processes continue to work. For example, the setting of environment variables and paths.

concurrencylabs commented 6 years ago

FYI... haven't forgotten about this PR. We're trying to make it work with existing stacks in both cross-account and single account scenarios and it's taking some time to set it up and test it. Will soon come back with a commit.

concurrencylabs commented 6 years ago

I had to make a number of changes to this PR, in order to make it work with the way the tool it's currently used, especially in cross-account scenarios. They should be compatible with the way you're using it, except you need to make sure S3 prefixes that are passed as parameters in the SAM template end in a "/". More details here:

Thanks for all the improvements!

Nr18 commented 6 years ago

You're welcome