Closed h-vetinari closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Seems the test libs don't get installed by default either...
I seem to remember that missing aligned alloc cannot be solved with -D_LIBCPP_DISABLE_AVAILABILITY
, which I'm already setting here. Or am I missing something @isuruf?
$WORK/absl/functional/internal/any_invocable.h:624:28: error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer
state_.remote.target = ::new T(std::forward<Args>(args)...);
I also tried setting only MACOSX_SDK_VERSION to 10.13, but the error remains the same. Will now also bump MACOSX_DEPLOYMENT_TARGET (edit: managed to do it only for the test output)
@conda-forge/abseil-cpp, this is ready now. It's required to build the new protobuf version, so even though I wasn't particularly motivated to chase down the compilation errors that needed a bunch of patches, it should now be good to go. Does someone want to have a look? 🙃
Protobuf wants
absl::scoped_mock_log
to build (with tests, which I'd like to not disable), but abseil declares that as a test-only dep which isn't built by default.Let's build them to unblock https://github.com/conda-forge/libprotobuf-feedstock/pull/144
Closes #57 Closes #55 Closes #48