conda-forge / airflow-feedstock

A conda-smithy repository for airflow.
BSD 3-Clause "New" or "Revised" License
6 stars 17 forks source link

Py 310 #81

Closed marcelotrevisani closed 2 years ago

marcelotrevisani commented 2 years ago

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

marcelotrevisani commented 2 years ago

@conda-forge-admin please rerender

xylar commented 2 years ago

Hi @marcelotrevisani, thanks for trying this out. The approach for migrating to python 3.10 is a little different from what you're trying to do.

I would be willing to try migrating, though. But I'm a little concerned because it seems that the latest release doesn't officially support python 3.10 yet: https://github.com/apache/airflow/blob/2.2.4/setup.cfg#L56-L59

Do you have reason to think it will work anyway?

xylar commented 2 years ago

@marcelotrevisani, the process for migrating to python 3.10 (and in general for updating the versions of pinned packages maintained in https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/conda_build_config.yaml) is to copy the migrator file into .ci_support/migrations as I have done in #82. It's a process that should be taken care of either by a relatively expert conda-forge maintainer or by the bot that handles migration. You can monitor package migration here: https://conda-forge.org/status/

marcelotrevisani commented 2 years ago

I was testing the image first to see if it was going to pass

xylar commented 2 years ago

@marcelotrevisani, I see. The rerender just undoes the changes you made, unfortunately.

I see from your website that you're a conda-forge core member so sorry for talking to you as if you don't know what you're doing. No offense meant, I just know some folks come to conda-forge without much knowledge of how things work.

marcelotrevisani commented 2 years ago

just checking if the smithy needed to do any other modification because the image failed before

marcelotrevisani commented 2 years ago

@marcelotrevisani, I see. The rerender just undoes the changes you made, unfortunately.

I see from your website that you're a conda-forge core member so sorry for talking to you as if you don't know what you're doing. No offense meant, I just know some folks come to conda-forge without much knowledge of how things work.

no worries mate :)

marcelotrevisani commented 2 years ago

I am closing this, I was just doing some test if python 3.10 could be added here, but maybe we will need a new release from airflow, thanks :)

xylar commented 2 years ago

Okay, let me know if there's anything I can do to help. I'll see what happens with #82. It would at least be interesting to know if there are dependencies that aren't migrated and maybe need attention.

marcelotrevisani commented 2 years ago

adding this for reference https://github.com/apache/airflow/pull/22050