search

conda-forge / ale-py-feedstock

A conda-smithy repository for ale-py.
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

ROMs not included in release #19

Open pseudo-rnd-thoughts opened 1 month ago

pseudo-rnd-thoughts commented 1 month ago

Solution to issue cannot be found in the documentation.

Issue

@Tobias-Fischer Thanks for maintaining the project, in v0.9, we added the ROMs within the PyPI wheels (https://github.com/Farama-Foundation/Arcade-Learning-Environment/pull/516) However, the conda doesn't seem to have updated to do this. I would guess that during the compile stage, the ROMs are not downloaded and then packaged. Also, there don't seem to be any tests being run unless I've missed something

This is affecting Gymnasium downstream which uses the ROMs with ale-py (https://github.com/conda-forge/gymnasium-feedstock/pull/41)

Installed packages

.

Environment info

.

Tobias-Fischer commented 1 month ago

Would you be ok to open a PR @pseudo-rnd-thoughts? Or even better take over maintenance here?

pseudo-rnd-thoughts commented 1 month ago

I don't actually understand conda-forge at all, so I'm happy to be added as maintainer but I probably can't help too much. I'll have a look at what is happening for a PR but I don't understand the conda compile process at all