search

conda-forge / allennlp-feedstock

A conda-smithy repository for allennlp.
BSD 3-Clause "New" or "Revised" License
0 stars 8 forks source link

Tracker for new dependencies #32

Open h-vetinari opened 2 years ago

h-vetinari commented 2 years ago

Packaging allennlp has been a bit of a moving target in terms of dependencies, which can cause delays, especially if those packages aren't in conda-forge yet (recent examples: torchvision, cached_path, fairscale).

Since it's not possible to continuously follow every upstream PR, we would only find out about new dependencies once there's a new release, and in a case like fairscale, that starts a clock that might take 2-3 weeks or more to complete.

Therefore, it would help immensely if people from allenai (CC @dirkgr @epwalsh) could use this issue to let us know once a new dependency is added, so we can have a head start to prepare it before the respective allennlp-release, allowing us to more closely track the upstream release cycle.

h-vetinari commented 2 years ago

If it helps, I can also open such a tracker on the allennlp-repo, but I didn't want to pollute your issue tracker with something that's going to be open long-term.

dirkgr commented 2 years ago

This is fine, but I worry we'll forget about it when it matters most. Is there a way we could set up some automation that creates an issue when requirements.txt in main changes?

h-vetinari commented 2 years ago

Well, it's not about every single changed version range, and just about new dependencies. I'm pretty sure those get added with some degree of deliberation? 😅

That said, automating this might be possible with github actions?

dirkgr commented 2 years ago

If we added dependencies all the time it would be easier to remember to do something special. But since it only happens every once in a while, that's harder.

h-vetinari commented 2 years ago

Well, it's also not the end of the world if it gets forgotten - it just means a given release will be delayed somewhat on conda-forge. I'll do what I can to keep it short, but some dependencies are tricker than others, and I do this in my free time. In any case, if you want to reduce that delay, you can either try to remember to let me know here or try to set up a github-action that does something that I can subscribe to (e.g. comment in an issue, etc.).