search

conda-forge / ambertools-feedstock

A conda-smithy repository for ambertools.
BSD 3-Clause "New" or "Revised" License
8 stars 14 forks source link

Update 23 final #112

Closed jaimergp closed 1 year ago

jaimergp commented 1 year ago

Checklist

Closes #97

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jaimergp commented 1 year ago

Large diff due to bringing changes from rc here. The real diff is 5c6a7d7.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

dacase commented 1 year ago

Does something else need to be done here? There is nothing yet at anaconda.org/conda-forge/ambertools. Or should I just be patient?

...thanks...

jaimergp commented 1 year ago

See this commit message:https://github.com/conda-forge/ambertools-feedstock/commit/2e3abe6863c387c92f126a99eb73472a2bbcde87#comments

mattwthompson commented 1 year ago

Did CI run? I don't see any status checks on commit 2e3abe6 or the feedstock https://dev.azure.com/conda-forge/feedstock-builds/_build?definitionId=6854

Oh, wait, I see now you kicked it yourself

jaimergp commented 1 year ago

Yea, had to retrigger manually; sometimes the CI events are dropped but an empty commit fixes it.

dacase commented 1 year ago

I guess I need more hand-holding here: Should there be AmberTools 23 files at anaconda.org/conda-forge/ambertools? The comments above say it may take 2-3 hours to appear, but I don't see anything yet. My plan is to update our web page to point users to AT23, once the final naming scheme is complete.

mattwthompson commented 1 year ago

I'm confused as well. In my experience it takes less than 2-3 hours, and never this long (if that is the reason, I'm skeptical)

The re-run of CI that Jaime did appears to have worked: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=700855&view=results

But the files are not there: https://anaconda.org/conda-forge/ambertools/files

I haven't seen this before - I've seen the builds fail and not appear, but not pass and fail to appear. Okay, now that I'm typing this, I realize that GitHub had an outage earlier today around this time. I wouldn't think that's the cause since I thought the tarball just needs to move from Azure to Anaconda Cloud, but maybe that's all done by a bot on GitHub, I don't know. My next recourse is checking the gitter channel (at this link) where, if there is a widespread problem, somebody else will have shouted it out.

So you're not alone - I've been working on conda packaging for several years and I'm stumped. Sorry I couldn't be more helpful, but Jaime probably knows what's going on here.

jaimergp commented 1 year ago

Nah, nothing weird due to outages, just a mistake I made. I had enabled a setting to prevent accidental uploads when I created the rc branch, and then forgot to revert once I merged that to main. Added one more commit with the fix. Things should be there in ~1h. Sorry!

mattwthompson commented 1 year ago

I see everything online now!