conda-forge / ambertools-feedstock

A conda-smithy repository for ambertools.
BSD 3-Clause "New" or "Revised" License
8 stars 14 forks source link

Rebuild for arpack38 #125

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update arpack38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6374840071, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mikemhenry commented 1 year ago

Websites prove their identity via certificates, which are valid for a set time period. The certificate for ambermd.org expired on 9/21/2023.

Looks like ambermb.org needs to update the ssl cert @dacase

Happy to help evaluate if Let'S Encrypt can be used. It will automate certificate renewal (and is free).

mattwthompson commented 1 year ago

We should park this until #124 is resolved, or vice versa - there could be actual issues with new versions of these upstreams, but as it stands these PRs will have duplicated (and potentially diverging) effort getting the existing builds back online

mikemhenry commented 1 year ago

I don't want to duplicate effort or end up doing work that diverges, but if this works with non-https, I don't see a reason to not merge it in

mikemhenry commented 1 year ago

I'll mark it as a draft though to make sure we focus on the other one first if the fix isn't easy.

mattwthompson commented 1 year ago

Fair enough - I'm advocating for one of these to be the "here's where changes not directly related to the actual PR" goes, indifferent as to where. And if there are actually boost/cpptraj issues as the other PR's CI implies, here would be a better place

mikemhenry commented 1 year ago

Got it, I was thinking if I got lucky and this one was green it would be good to go, but it does look like the real errors have nothing to do with either rebuild PRs and would show up if we just bumped the build number for fun*.

*for some definition of fun

mattwthompson commented 1 year ago

@conda-forge-admin, please restart ci

mikemhenry commented 1 year ago

@mattwthompson If CI passes I think we can merge this, it passed with http but might as well go back to https to reduce a merge conflict or something (it doesn't add anything to security or data integrity wise since we check that sha256 hash of the tarball).

mikemhenry commented 1 year ago

@mattwthompson automerge on :sunglasses:

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!