conda-forge / ambertools-feedstock

A conda-smithy repository for ambertools.
BSD 3-Clause "New" or "Revised" License
8 stars 14 forks source link

Rebuild for libboost 1.82 #126

Closed regro-cf-autotick-bot closed 12 months ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update boost_cpp_to_libboost.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6425647107, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mikemhenry commented 1 year ago

These are the errors from the osx-64 and osx-arm64

2023-10-06T01:41:17.8020210Z /Users/runner/miniforge3/conda-bld/ambertools_1696552439471/work/AmberTools/src/leap/src/Wc/WcActCB.c:316:5: error: incompatible function pointer types passing 'void (Widget, XtGrabKind)' (aka 'void (struct _WidgetRec *, XtGrabKind)') to parameter of type 'PFVWidInt' (aka 'void (*)(struct _WidgetRec *, int)') [-Wincompatible-function-pointer-types]
2023-10-06T01:41:17.8021260Z                          XtPopup, XtGrabNone );
2023-10-06T01:41:17.8022180Z                          ^~~~~~~
2023-10-06T01:41:17.8025180Z /Users/runner/miniforge3/conda-bld/ambertools_1696552439471/work/AmberTools/src/leap/src/Wc/WcActCB.c:323:5: error: incompatible function pointer types passing 'void (Widget, XtGrabKind)' (aka 'void (struct _WidgetRec *, XtGrabKind)') to parameter of type 'PFVWidInt' (aka 'void (*)(struct _WidgetRec *, int)') [-Wincompatible-function-pointer-types]
2023-10-06T01:41:17.8026070Z                          XtPopup, XtGrabExclusive );
2023-10-06T01:41:17.8026340Z                          ^~~~~~~
2023-10-06T01:41:17.8103750Z /Users/runner/miniforge3/conda-bld/ambertools_1696552439471/work/AmberTools/src/leap/src/Wc/WcActCB.c:916:23: error: incompatible function pointer types passing 'void (Widget, const char *, XtCallbackList)' (aka 'void (struct _WidgetRec *, const char *, struct _XtCallbackRec *)') to parameter of type 'AddOrRemoveProc' (aka 'void (*)(struct _WidgetRec *, char *, struct _XtCallbackRec *)') [-Wincompatible-function-pointer-types]
2023-10-06T01:41:17.8104400Z                                 "WcAddCallbacks", XtAddCallbacks );
2023-10-06T01:41:17.8104690Z                                                   ^~~~~~~~~~~~~~
2023-10-06T01:41:17.8107390Z /Users/runner/miniforge3/conda-bld/ambertools_1696552439471/work/AmberTools/src/leap/src/Wc/WcActCB.c:926:26: error: incompatible function pointer types passing 'void (Widget, const char *, XtCallbackList)' (aka 'void (struct _WidgetRec *, const char *, struct _XtCallbackRec *)') to parameter of type 'AddOrRemoveProc' (aka 'void (*)(struct _WidgetRec *, char *, struct _XtCallbackRec *)') [-Wincompatible-function-pointer-types]
2023-10-06T01:41:17.8107970Z                                 "WcRemoveCallbacks", XtRemoveCallbacks );
2023-10-06T01:41:17.8108230Z                                                      ^~~~~~~~~~~~~~~~~
h-vetinari commented 12 months ago

@conda-forge-admin, please rerender

h-vetinari commented 12 months ago

@dacase @conda-forge/ambertools This is now green so we could merge. However, ambertools is not compatible with newer compilers anymore - clang 15 errors on some now-forbidden conversions between differen function pointers, and clang 16 will start erroring out for function definitions without a prototype. It would be good to make the upstream code compatible - do you need us to raise an issue for that?

dacase commented 12 months ago

I'll send a message to Scott Brozell, to see if he has time to look at this: (Scott: see errors above.) This code is not even our code: it was written probably 30 years ago, back when X-windows was still the way one built many GUI programs. Very few Amber developers would be using OSX or clang, and this is the only GUI program we have. But with specific line numbers, it may be possible to make some explicit casts even without having a clue about what the code really does. It looks like it is pretty easy to install clang16 on Linux, so we can see if the same errors pop up there, or whether this is somehow OSX-specific.

dacase commented 12 months ago

I've created issue #127 for this topic, which is probably a better place for discussion.