Noarch version - Githubissues

conda-forge / anndata-feedstock

A conda-smithy repository for anndata.

BSD 3-Clause "New" or "Revised" License

1 stars 10 forks source link

Noarch version #21

Closed HeavyTony2 closed 2 years ago

HeavyTony2 commented 2 years ago

Added the missing dependancy xlrd <2.0 and set it as noarch.

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

HeavyTony2 commented 2 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

HeavyTony2 commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/anndata-feedstock/actions/runs/2029073039.

ivirshup commented 2 years ago

We also no longer rely on xlrd, so it probably shouldn't be added to the dependency list.

I was wondering, does noarch imply we can't have python version restrictions?

HeavyTony2 commented 2 years ago

We also no longer rely on xlrd, so it probably shouldn't be added to the dependency list.

I was wondering, does noarch imply we can't have python version restrictions?

Sorry for the late answer. The answer is no. In fact, with a noarch version you have to set a python version restriction. The typical one is python >=3.6 but it could be python <=4 too for example.

HeavyTony2 commented 2 years ago

@conda-forge-admin, please rerender