conda-forge / arrow-cpp-feedstock

A conda-smithy repository for arrow-cpp.
BSD 3-Clause "New" or "Revised" License
10 stars 61 forks source link

Dependency TODOs: enablements & clean-ups #944

Open h-vetinari opened 1 year ago

h-vetinari commented 1 year ago

From looking at the list of third-party deps, we could still do better with:

Switch to shared builds for (if/once available):

Bindings:

xhochy commented 1 year ago

We cannot unvendor jemalloc as the build is with special options. Unverdoring it would have an impact on the default allocator.

jakirkham commented 1 year ago

Would it be possible to just build a variant of the jemalloc package with options needed?

jakirkham commented 1 year ago

Would not count on ucx being supported on other ~architectures~ OSes. Would also like to understand why that is relevant

h-vetinari commented 1 year ago

Would also like to understand why that is relevant

I have a maximalist approach to packaging the bindings offered by a given library -- if the library offers integration for it, why shouldn't we package it?[^1]

Users rely on conda-forge because a lot of these packages are really hard to build from source, so if a binding is not supported by us, it's effectively unusuable (even moreso if the distributed wheels also turn it off).

[^1]: whether to break a package into separate outputs is a separate question

jakirkham commented 1 year ago

Sorry I should clarify, what I mean is why are other OSes relevant? Asking since ucx likely will remain Linux only (possibly macOS at some point and basically no chance of Windows support)

h-vetinari commented 1 year ago

Sorry I should clarify, what I mean is why are other OSes relevant? Asking since ucx likely will remain Linux only (possibly macOS at some point and basically no chance of Windows support)

Not relevant indeed, unless they become: a) available for the respective platform & b) are supported by arrow on that platform.