search

conda-forge / artifact-validation

code and workflows to validate conda-forge artifacts
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

[warning] 2022-04-11 09:26:00 UTC - invalid artifacts #820

Open conda-forge-curator[bot] opened 2 years ago

conda-forge-curator[bot] commented 2 years ago

Hey @conda-forge/systems!

It appears that we found some invalid artifacts:

+arm_pyart:
+  win-64/arm_pyart-1.12.1-py310h2873277_0.tar.bz2:
+    bad_paths:
+      certifi.python.generated:
+      - Lib/site-packages/certifi-*.egg-info/**/*
+      - Lib/site-packages/certifi/**/*
+      requests.python.generated:
+      - Lib/site-packages/requests-*.egg-info/**/*
+      - Lib/site-packages/requests/**/*
+      scipy.python.generated:
+      - Lib/site-packages/scipy-*.egg-info/**/*
+      - Lib/site-packages/scipy/**/*
+  win-64/arm_pyart-1.12.1-py38hbdcd294_0.tar.bz2:
+    bad_paths:
+      certifi.python.generated:
+      - Lib/site-packages/certifi-*.egg-info/**/*
+      - Lib/site-packages/certifi/**/*
+      requests.python.generated:
+      - Lib/site-packages/requests-*.egg-info/**/*
+      - Lib/site-packages/requests/**/*
+      scipy.python.generated:
+      - Lib/site-packages/scipy-*.egg-info/**/*
+      - Lib/site-packages/scipy/**/*
+  win-64/arm_pyart-1.12.1-py39h5d4886f_0.tar.bz2:
+    bad_paths:
+      certifi.python.generated:
+      - Lib/site-packages/certifi-*.egg-info/**/*
+      - Lib/site-packages/certifi/**/*
+      requests.python.generated:
+      - Lib/site-packages/requests-*.egg-info/**/*
+      - Lib/site-packages/requests/**/*
+      scipy.python.generated:
+      - Lib/site-packages/scipy-*.egg-info/**/*
+      - Lib/site-packages/scipy/**/*

We might want to mark these as broken if they are serious!

beckermr commented 2 years ago

@conda-forge/arm_pyart We've found some files in your windows artifacts that don't appear to belong there. Can you investigate this and fix it?

zssherman commented 2 years ago

@beckermr, hmm is there any reason why these would appear? I've never seen this before. We built the tar file on Linux and then uploaded it to condaforge from pypi. We removed the win builds for 3.7 due to dependency issues. But these look to be win 3.8 etc. all related to scipy. Wondering if it was a compiling issue or when we built the tar file. Or is this usually feedstock related and we have to fix something there?

beckermr commented 2 years ago

I'd open up the packages and see what files are there. Many times people run tests in the build phase instead of the test phase and this causes issues.

zssherman commented 2 years ago

@beckermr Ah gotcha, and are these the tests running in the feedstocks typically then? My apologies for all the questions. If so, ill take a look to see where out tests are being ran

zssherman commented 2 years ago

we did a new PR, we were missing setuptools as well as a few other things that might have been causing possible issues, so we did a new build and hopefully that fixes it.

beckermr commented 2 years ago

Do you have a link to the PR?

We should mark these files as broken here: conda-forge/admin-requests.

zssherman commented 2 years ago

@beckermr This is the PR that possibly caused the issue: https://github.com/conda-forge/arm_pyart-feedstock/pull/52 and this is our attempted fix for it: https://github.com/conda-forge/arm_pyart-feedstock/pull/53

beckermr commented 2 years ago

I made a PR to try and simplify things. Hopefully it works!

zssherman commented 2 years ago

Oh gotcha! Thank you for doing that!