conda-forge / astropy-feedstock

A conda-smithy repository for astropy.
BSD 3-Clause "New" or "Revised" License
5 stars 17 forks source link

Rebuild for Python 3.11 #109

Closed duncanmmacleod closed 1 year ago

duncanmmacleod commented 1 year ago

This PR manually implements the Python 3.11 migration, including a shift of the exact pin for markupsafe.

I do not understand the implications of changing the markupsafe pin, but this was required to be able to solve the host requirements for py311.

Checklist

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mwcraig commented 1 year ago

What is the motivation for the manual migration instead of waiting for the bot (I'm not opposed to it just want to understand)

duncanmmacleod commented 1 year ago

What is the motivation for the manual migration instead of waiting for the bot (I'm not opposed to it just want to understand)

The key is the markupsafe pin. markupsafe=2.0.1 is not available for py311 so the bot will never solve.

mwcraig commented 1 year ago

Thanks for doing this @duncanmmacleod -- merging!