conda-forge / bipedal-locomotion-framework-feedstock

A conda-smithy repository for bipedal-locomotion-framework.
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Switch from yarp-cxx to libyarp #50

Closed traversaro closed 10 months ago

traversaro commented 10 months ago

Now the C++ part (without the python bindings) is available in the libyarp package, not yarp-cxx anymore.

See:

Furthermore, I added the additional python checks to ensure that problems such as the one reported in https://github.com/conda-forge/bipedal-locomotion-framework-feedstock/issues/48 do not occur in the future.

Checklist

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

traversaro commented 10 months ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 10 months ago

You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

Sorry kind bot, you are right. Fixed in https://github.com/conda-forge/bipedal-locomotion-framework-feedstock/pull/50/commits/3d3dcc27140b6e298932edb01c0bb4a6fb1f6a4f .

traversaro commented 10 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 10 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!