conda-forge / bitsandbytes-feedstock

A conda-smithy repository for bitsandbytes.
BSD 3-Clause "New" or "Revised" License
1 stars 4 forks source link

Bundle CPU .so even when building CUDA backend #19

Closed iamthebot closed 1 month ago

iamthebot commented 1 month ago

In #14 we fixed the CUDA .so file not being included in CUDA enabled builds. However, one problem is that bitsandbytes relies on both the presence of CUDA libraries and a GPU working w/ that CUDA version to detect which native lib to load.

On a system with CUDA installed but without a GPU this will cause problems because we don't bundle in the non-CUDA .so in the conda package in that case. We encountered during an import of bitsandbytes on a Ray head node.

This modifies the build to always build the libbitsandbytes_cpu.so even during a CUDA enabled build. This enables non-GPU fallback to work correctly.

I've also added two fellow contributors willing to do some maintenance work on this feedstock.

Checklist

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

shaowei-su commented 1 month ago

LGTM, please help add @shaowei-su as maintainers if possible, thanks.

iamthebot commented 1 month ago

@xhochy PTAL, thanks!

iamthebot commented 1 month ago

@xhochy comments addressed, PTAL. Would love to get this merged in since it's blocking us.