BLD: 2 latest hdf5 versions

conda-forge / bmad-feedstock

A conda-smithy repository for bmad.

BSD 3-Clause "New" or "Revised" License

1 stars 6 forks source link

BLD: 2 latest hdf5 versions #479

Closed ken-lauer closed 2 days ago

ken-lauer commented 2 days ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Context: #478

ken-lauer commented 2 days ago

@conda-forge-admin, please rerender

conda-forge-admin commented 2 days ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

ken-lauer commented 2 days ago

@conda-forge-admin, please rerender

ken-lauer commented 2 days ago

Seems like the migration yaml got in the way of making hdf5 build variants? Hmm, removed it - let's try again

ken-lauer commented 2 days ago

Well, it's working but it's painfully long...

ken-lauer commented 2 days ago

Is it worth going in this direction until the h5py issue is addressed? Or would you rather revert the hdf5 PR and just rely on the old version for now?

hhslepicka commented 2 days ago

I think it is valid if the experience for the package user is transparent when they ask to install bmad with h5py in an environment and it picks up the proper versions.

Thank you very much for looking into this. Once the upstream issue with h5py is fixed we can remove the variant.