patch for _Py_fopen -> fopen

conda-forge / boost-feedstock

A conda-smithy repository for boost.

BSD 3-Clause "New" or "Revised" License

15 stars 41 forks source link

patch for _Py_fopen -> fopen #110

Closed mattip closed 3 years ago

mattip commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Adopt upstream boostorg/python#344. Should be enough to get the PyPy3.7 migration to pass.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattip commented 3 years ago

@conda-forge-admin, please rerender

mattip commented 3 years ago

this replaces all the open migration PRs #96 #106 #107 #108 #109 which can be closed.

isuruf commented 3 years ago

They can't be replaced, unless you copy the .ci_support/migrations/pypy*.yaml files here.

mattip commented 3 years ago

ahh. So what happens to those PRs if this gets merged?

isuruf commented 3 years ago

They'll have to be rebased.

isuruf commented 3 years ago

@conda-forge-admin, rerender

mattip commented 3 years ago

Nope. boost is using internal structures

$BUILD_PREFIX/x86_64-conda-linux-gnu/include/c++/9.3.0/bits/unique_ptr.h:53:28: note: declared here
   53 |   template<typename> class auto_ptr;
      |                            ^~~~~~~~
libs/python/src/wrapper.cpp: In member function 'boost::python::override boost::python::detail::wrapper_base::get_override(const char*, PyTypeObject*) const':
libs/python/src/wrapper.cpp:28:50: error: 'struct PyMethodObject' has no member named 'im_self'
   28 |                   && ((PyMethodObject*)m.get())->im_self == this->m_self
      |                                                  ^~~~~~~
      |    ^~~~~~~~~~~~~~
./boost/python/detail/is_auto_ptr.hpp:17:1: note: in expansion of macro 'BOOST_PYTHON_IS_XXX_DEF'
   17 | BOOST_PYTHON_IS_XXX_DEF(auto_ptr, std::auto_ptr, 1)
      | ^~~~~~~~~~~~~~~~~~~~~~~

mattip commented 3 years ago

Deeper into the rabbit hole: on latest HEAD that problem is gone. It was fixed in boostorg/python#291

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
drone: passed
travis: passed
azure: passed

Thus the PR was passing and merged! Have a great day!