Backported patch to fix double-digit minor python version in BoostConfig.cmake

conda-forge / boost-feedstock

A conda-smithy repository for boost.

BSD 3-Clause "New" or "Revised" License

15 stars 41 forks source link

Backported patch to fix double-digit minor python version in BoostConfig.cmake #131

Closed ckoern closed 2 years ago

ckoern commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Boost 1.74 fails to recognise python 3.10, which was fixed in 1.78. As this bug makes the build of other feedstocks fail for python 3.10 (e.g. conda-forge/geant4-feedstock#33), it should be worth backporting the fix

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ckoern commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/boost-feedstock/actions/runs/1751140478.

xhochy commented 2 years ago

This should also be backported to 1.76 probably?

ckoern commented 2 years ago

I have realised, that the BoostConfig.cmake is not packed in the final package output but that this file is instead provided by boost-cpp, so this PR actually has no effect. Sorry about that!

I will make a PR in boost-cpp instead.