search

conda-forge / boost-feedstock

A conda-smithy repository for boost.
BSD 3-Clause "New" or "Revised" License
15 stars 41 forks source link

backport patch for removed-in-C++17 std::{binary,unary}_function (yet again) #180

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

Seems we get to relive https://github.com/conda-forge/boost-cpp-feedstock/issues/134 & https://github.com/conda-forge/boost-cpp-feedstock/pull/135, only slightly differently.

Still getting failures in https://github.com/conda-forge/graph-tool-feedstock/pull/114 of the kind:

In file included from ./src/graph/histogram.hh:26:
In file included from $PREFIX/include/boost/multi_array.hpp:34:
In file included from $PREFIX/include/boost/multi_array/multi_array_ref.hpp:32:
$PREFIX/include/boost/functional.hpp:45:24: error: no member named 'unary_function' in namespace 'std'; did you mean '__unary_function'?
            using std::unary_function;
                  ~~~~~^

That's because apparently, we're not automatically picking up _HAS_AUTO_PTR_ETC, which is the only guard from using the deprecated functions as of boost 1.82.

This got fixed (presumably the last time) in https://github.com/boostorg/functional/commit/6a573e4b8333ee63ee62ce95558c3667348db233, so backport that patch.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 1 year ago

@conda-forge/boost could someone please review? Given that the commit in question landed in boost 1.83, I think we should be safe to backport it, but would appreciate another set of eyes.

CC @conda-forge/graph-tool @traversaro