search

conda-forge / boost-feedstock

A conda-smithy repository for boost.
BSD 3-Clause "New" or "Revised" License
15 stars 41 forks source link

remove libboost run-export from libboost-python-devel #189

Closed h-vetinari closed 7 months ago

h-vetinari commented 7 months ago

In preparation for the 1.84 migration, which fixes this aspect of the 1.82 migration (c.f. #176)

Closes #191

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions[bot] commented 7 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

h-vetinari commented 7 months ago 
$PREFIX/x86_64-conda-linux-gnu/bin/ld: warning: libz.so.1, needed by $PREFIX/lib/libboost_iostreams.so, not found (try using -rpath or -rpath-link)

No idea why the old test_lib.sh started failing on linux, nor why libz.so.1 isn't found even though it's definitely in the test environment.

  environment location: /home/conda/feedstock_root/build_artifacts/boost-split_1706514658426/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac

The following NEW packages will be INSTALLED:

    _libgcc_mutex:            0.1-conda_forge     conda-forge
    _openmp_mutex:            4.5-2_gnu           conda-forge
    binutils_impl_linux-64:   2.40-hf600244_0     conda-forge
    binutils_linux-64:        2.40-hbdbef99_2     conda-forge
    bzip2:                    1.0.8-hd590300_5    conda-forge
    gcc_impl_linux-64:        12.3.0-he2b93b0_4   conda-forge
    gcc_linux-64:             12.3.0-h76fc315_2   conda-forge
    gxx_impl_linux-64:        12.3.0-he2b93b0_4   conda-forge
    gxx_linux-64:             12.3.0-h8a814eb_2   conda-forge
    icu:                      73.2-h59595ed_0     conda-forge
    kernel-headers_linux-64:  2.6.32-he073ed8_16  conda-forge
    ld_impl_linux-64:         2.40-h41732ed_0     conda-forge
    libboost:                 1.84.0-h8013b2b_1   local      
    libboost-devel:           1.84.0-h00ab1b0_1   local      
    libboost-headers:         1.84.0-ha770c72_1   local      
    libgcc-devel_linux-64:    12.3.0-h8bca6fd_104 conda-forge
    libgcc-ng:                13.2.0-h807b86a_4   conda-forge
    libgomp:                  13.2.0-h807b86a_4   conda-forge
    libsanitizer:             12.3.0-h0f45ef3_4   conda-forge
    libstdcxx-devel_linux-64: 12.3.0-h8bca6fd_104 conda-forge
    libstdcxx-ng:             13.2.0-h7e041cc_4   conda-forge
    libzlib:                  1.2.13-hd590300_5   conda-forge
    sysroot_linux-64:         2.12-he073ed8_16    conda-forge
    xz:                       5.2.6-h166bdaf_0    conda-forge
    zstd:                     1.5.5-hfc55251_0    conda-forge
h-vetinari commented 7 months ago

@conda-forge/boost Not sure what's happening here that broke the recipe (see also a vanilla rerun of current main in #191); the linker cannot find the compression libraries that are clearly in the environment, which is also specified in the linker-argument: https://github.com/conda-forge/boost-feedstock/blob/c9b675d65cc245834e46f7a60b51a1cd800df26b/recipe/test_lib.sh#L8-L10

In particular, we're already doing what the error tells us to do:

$PREFIX/x86_64-conda-linux-gnu/bin/ld: warning: libz.so.1, needed by $PREFIX/lib/libboost_iostreams.so, not found (try using -rpath or -rpath-link)

Adding -lbz2 -llzma -lzstd on that line does help, but zlib does not get found even with -lz; this may be because, as the comment notes, it's only the zlib integration that's being tested here.

h-vetinari commented 7 months ago

Not sure what's happening here that broke the recipe

OK, lucky timinig/coincidence for me to see this comment where @mbargull rootcaused a bug in conda-build 3.28 involving rpaths. Seems that we're also corrupting our rpath metadata here somehow, because things build fine with conda-build 3.27.