search

conda-forge / breathe-feedstock

A conda-smithy repository for breathe.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

breathe v4.13.0.post0 #18

Closed regro-cf-autotick-bot closed 5 years ago

regro-cf-autotick-bot commented 5 years ago

It is very likely that the current package version for this feedstock is out of date. Notes and instructions for merging this PR:

  1. Please check that the dependencies have not changed.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.
  4. The bot will almost always only open one PR per version.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

sdebionne commented 5 years ago

@SylvainCorlay v4.13.0.post0 fixes an annoying bug, see michaeljones/breathe#431. Could you consider generating a package please?

SylvainCorlay commented 5 years ago

Sure! I closed the bot PR because I presumed it was not meant as a release.

Quick note: did you guys consider making a patch release rather than using a post suffix?

sdebionne commented 5 years ago

I don't know why the choice of a post suffixed release (vs a patch release) was made. @melvinvermeeren ?

vermeeren commented 5 years ago

@sdebionne breathe 4.13.0 was initially released marked as python 2 and sphinx >= 1.8 compatible. However it turned out with the adaptations for sphinx 2 it was no longer fully compatible with sphinx 1, causing errors in some cases. Sphinx 2 in turn requires python >= 3.5.

The only diff between 4.13.0 and 4.13.0.post0 is the proper marking of dependencies and python version in the package info, see michaeljones/breathe#432.

I would have rather overwritten PyPI's 4.13.0 with the correct one, but the service does not allow this. It instead referred to making a new release or post release. As there are no code changes at all I felt a "bugfix" 4.13.1 wouldn't make sense, though the post0 is still ugly.

Edit: i.e. on a python 3 + sphinx 2.x environment 4.13.0 == 4.13.0.post0.

SylvainCorlay commented 5 years ago

@melvinvermeeren @sdebionne

I don't see a downside in tagging 4.13.1. Patch releases fixing up a release are fairly common.

Although, if you don't want to make a patch release just for that, and since the code does not change, why not just openning a PR to the conda recipe properly specifying the dependencies (and bumping the build number)?

I would be happy to get the previous build tagged as broken so that it does not get installed.