conda-forge / c-blosc2-feedstock

A conda-smithy repository for c-blosc2.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Fix double prefix in pkgconfig files #36

Closed apmorton closed 1 year ago

apmorton commented 1 year ago

Checklist

Prior to this change when trying to cross compile:

$ cat ../_h_env/lib/pkgconfig/blosc2.pc 
prefix=/home/conda/feedstock_root/build_artifacts/debug_1680560464317/_h_env
exec_prefix=${prefix}
libdir=${exec_prefix}//home/conda/feedstock_root/build_artifacts/debug_1680560464317/_h_env/lib

This causes pkg-config to output incorrect path, and ultimately the application fails to link.

$ pkg-config --libs blosc2
-L/home/conda/feedstock_root/build_artifacts/debug_1680560464317/_h_env//home/conda/feedstock_root/build_artifacts/debug_1680560464317/_h_env/lib -lblosc2
conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

Thank you for the investigation!

Good fix.

looking at the logs, it seems we can just remove this entirely:

CMAKE_ARGS=-DCMAKE_AR=$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-ar -DCMAKE_CXX_COMPILER_AR=$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-gcc-ar -DCMAKE_C_COMPILER_AR=$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-gcc-ar -DCMAKE_RANLIB=$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-ranlib -DCMAKE_CXX_COMPILER_RANLIB=$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-gcc-ranlib -DCMAKE_C_COMPILER_RANLIB=$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-gcc-ranlib -DCMAKE_LINKER=$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-ld -DCMAKE_STRIP=$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-strip -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER -DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY -DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=ONLY -DCMAKE_FIND_ROOT_PATH=$PREFIX;$BUILD_PREFIX/x86_64-conda-linux-gnu/sysroot -DCMAKE_INSTALL_PREFIX=$PREFIX -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_PROGRAM_PATH=$BUILD_PREFIX/bin;$PREFIX/bin
hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/c-blosc2-feedstock/actions/runs/4602111305.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!