conda-forge / c-blosc2-feedstock

A conda-smithy repository for c-blosc2.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

c-blosc2 v2.10.1 #42

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5725594506, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

it seems like the build files changed slightly between these two versions. @FrancescAlted are you able to identify the flags that should be updated?

FrancescAlted commented 1 year ago

Uh, not sure about that, sorry. Recently we have accepted this PR https://github.com/Blosc/c-blosc2/pull/537, and @ax3l has been very helpful in adding comments for the changes. I can only say that the changes did not affect the python-blosc2 package. Hope reading that PR would help your figuring out the needed changes for your setup.

FrancescAlted commented 1 year ago

A friendly reminder for @ax3l. Any idea on how your recent changes can affect to this conda build?

ax3l commented 1 year ago

Thanks for the ping! Sorry that I did not see it earlier. Let me take a look later today / tomorrow

ax3l commented 1 year ago

Hm, I cannot see the CI output. @hmaarrfk @FrancescAlted can you restart them and copy the output here?

I think it's about the externally provided zlib-ng and how to exactly search for it with find_package.

ax3l commented 1 year ago

Got it - I installed the CF env locally and debugged it. Here is the patch to improve the shipped FindZLIB_NG.cmake: https://github.com/Blosc/c-blosc2/pull/541

FrancescAlted commented 1 year ago

I have merged https://github.com/Blosc/c-blosc2/pull/541, but not sure if re-running this will pull the latest git version. Trying that anyway.

ax3l commented 1 year ago

I will provide one more patch and then we can do a patch release (or pull the two PRs here).

ax3l commented 1 year ago

This is the other PR we will need to build downstream projects if C-Blosc2 used external dependencies, as it does on conda-forge: https://github.com/Blosc/c-blosc2/pull/542

ax3l commented 1 year ago

@hmaarrfk @FrancescAlted Do you like to wait for 2.10.2 to be tagged, then replace this PR on conda-forge with it? Otherwise we can patch the two linked PRs into meta.yaml for the current CF PR in here. Let me know what you prefer and I can help with it.

FrancescAlted commented 1 year ago

@hmaarrfk @FrancescAlted Do you like to wait for 2.10.2 to be tagged, then replace this PR on conda-forge with it? Otherwise we can patch the two linked PRs into meta.yaml for the current CF PR in here. Let me know what you prefer and I can help with it.

I am planning to release 2.10.2 soon (tomorrow?), so +1 for waiting.

ax3l commented 1 year ago

That is great, I would do the same. The conda-forge bot should pick it up automatically after a few hrs/days and open another PR for it. Merging that v2.10.2 PR will automatically close the one here in #42.