search

conda-forge / c-blosc2-feedstock

A conda-smithy repository for c-blosc2.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Unbundle libraries #7

Closed hmaarrfk closed 2 years ago

hmaarrfk commented 2 years ago

This package seems to bundle zlib and zstd an lz4 https://github.com/Blosc/c-blosc2/tree/main/internal-complibs

hmaarrfk commented 2 years ago

Not sure why zlib Ng is still falling in windows

zklaus commented 2 years ago

@hmaarrfk, going through this repo, is it true that this issue together with PRs #9, #10, and #14, is addressed by now?

hmaarrfk commented 2 years ago

Not for windows

zklaus commented 2 years ago

Right. So for everything except Windows this is done and only one of the three PRs linked above should be pursued further, correct? Which one would that be? Can we close the others?

hmaarrfk commented 2 years ago

Sorry for letting them linger for so long.

Some were me testing things out. Others were debugging an actual bug in the original version. I closed them all.

You are correct that we still need to unbundle windows. I figured the accepted PR was a move in the right direction, so I merged it. Your help would be greatly apprecaited. I feel like there is a bug somewhere in my defined constants. Maybe in looking for the library?