search

conda-forge / calculix-feedstock

A conda-smithy repository for calculix.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #1

Closed regro-cf-autotick-bot closed 5 years ago

regro-cf-autotick-bot commented 5 years ago

It is likely this feedstock needs to be rebuilt. Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo commented 5 years ago

@conda-forge/core I think thus PR is incomplete. There is missing builds for the new tool-chain ( gcc7)

scopatz commented 5 years ago

That probably has to do with the fact that this recipe switches compiler based on platform

looooo commented 5 years ago

thanks for the information. Is it possible to do it manually?

jakirkham commented 5 years ago

@conda-forge-admin, please re-render.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 5 years ago

I think thus PR is incomplete.

There was a change in conda-build that broke conda-smithy and thus broke PRs generated for the rebuild. That was recently fixed. ( https://github.com/conda-forge/conda-smithy/pull/962 )

Re-rendering is sufficient to fix the issue. Have done so and fixed some merge conflicts as well. Sorry it got a little messy.

Hopefully this is all that is needed, but let us know if you have other issues.

looooo commented 5 years ago

Thanks @jakirkham .I guess it's best to remove the old tool-chain for osx, or use GCC there.

jakirkham commented 5 years ago

Given as it looks you want to start using OpenMP, dropping the legacy compiler builds on macOS makes sense. Have pushed a few small changes to this PR so that future re-renderings will not readd the legacy compilers builds on macOS. Hope that is ok.

jakirkham commented 5 years ago

Pushed a commit for LLVM OpenMP support on macOS. That should be all that is needed, but I don't know too much about this package. So happy to discuss if there are issues.

looooo commented 5 years ago

thanks @jakirkham, I wonder why the openmp flag is set anyway. I guess openmp is not used in the build.

jakirkham commented 5 years ago

Seems this call to clang uses -fopenmp. Maybe that is a change introduced by the new version? Am only speculating though. You would know more than me. 😉

Edit: Though it doesn't appear to link to libomp. So maybe it is not really used except for Fortran code (where it does link to libgomp). Meaning maybe this is an issue in their build system.

looooo commented 5 years ago

The make file is used from the source and some stuff is rewritten. I merge this for now and wonder about openmp when ever I have time.... Thanks again!