update to 0.7.2 - Githubissues

conda-forge / camelot-py-feedstock

A conda-smithy repository for camelot-py.

BSD 3-Clause "New" or "Revised" License

1 stars 11 forks source link

update to 0.7.2 #11

Closed pvanheus closed 5 years ago

pvanheus commented 5 years ago

update pdfminer.six dependency to capture the version with python 3.7 support

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pvanheus commented 5 years ago

@conda-forge-admin, please rerender

pvanheus commented 5 years ago

The build is failing because it (or, I suspect, OpenCV) depends on libGL.so.1 which is something provided along with a specific graphics driver.

vinayak-mehta commented 5 years ago

Hey @pvanheus, sorry for being inactive here. Let me look into this on Sunday.

pvanheus commented 5 years ago

@conda-forge-admin, please rerender

pvanheus commented 5 years ago

@conda-forge-admin, please rerender

Hey @pvanheus, sorry for being inactive here. Let me look into this on Sunday.

No worries, thanks for the awesome camelot-py package.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

vinayak-mehta commented 5 years ago

All checks have passed! Should I merge this? Though I'm not sure about the changes that you did. Will review them first, would help if you can give a small summary :)

pvanheus commented 5 years ago

All checks have passed! Should I merge this? Though I'm not sure about the changes that you did. Will review them first, would help if you can give a small summary :)

I updated the pdfminer.six package and made that noarch. This dependency was causing problems for camelot-py.
I changed the build line to the recommended pip based installation method and added pip as a host requirement.
I added a yum_requirements.txt file that specified mesa-libGL as a dependency so that the tests pass.
I asked for a re-render. This is actually the step that led to the majority of the changes in this PR (done by the re-render bot).

pvanheus commented 5 years ago

@vinayak-mehta given the summary above, can you perhaps merge this PR or is there more that you would like to review / discuss?

vinayak-mehta commented 5 years ago

Merged. Thanks for the changes!