conda-forge / cartopy-feedstock

A conda-smithy repository for cartopy.
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

Rebuild for geos390 #102

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

This PR has been triggered in an effort to update geos390.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/509429775, please use this URL for debugging

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

xylar commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

xylar commented 3 years ago

Just testing if error_overlinking might be related to the window error.

xylar commented 3 years ago

@isuruf, you had suggested that we add error_overlinking: true. It's now causing errors related to:

 ERROR (cartopy,Lib/site-packages/cartopy/trace.cp39-win_amd64.pyd): $RPATH/api-ms-win-crt-math-l1-1-0.dll not found in packages, sysroot(s) nor the missing_dso_whitelist.

When I remove error_overlinking, these become warnings but I'm not at all sure that's a safe thing to do.

I'm not good with Windows but my Googling suggests that the DLL causing trouble is part of VC somehow.

Any advice?

isuruf commented 3 years ago

Thanks for letting me know. I've fixed a bug introduced recently into the vc package. Can you try in another hour or so?

xylar commented 3 years ago

@isuruf, thank you very much for looking into this. We're still seeing the issue. I'll try again in another hour just in case but I think it's been long enough that the changes you made should have propagated.

xylar commented 3 years ago

@isuruf, have you by chance had any luck figuring this one out? This seems to be the last open PR related to geos 3.9.0, so might be nice to complete the migration.

xylar commented 3 years ago

Hmm, I just realized that geos 3.9.1 went in fine, so I'll try rebasing and see if that helps.

xylar commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

xylar commented 3 years ago

@conda-forge-admin, please rerender

xylar commented 3 years ago

I'll add back the geos 3.9.1 migrator in #104

isuruf commented 3 years ago

@isuruf, have you by chance had any luck figuring this one out?

Yeah, fixed it in vc-feedstock. Forgot to report here.

xylar commented 3 years ago

Thanks again!