build of 0.18.0b1 - Githubissues

xylar commented 4 years ago

This is just to make sure there aren't any unpleasant surprises, see: https://github.com/SciTools/cartopy/issues/1458

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 4 years ago

@conda-forge-admin, please rerender

xylar commented 4 years ago

The windows build errors must be related to this somehow: https://github.com/SciTools/cartopy/blob/master/setup.py#L244-L247

I don't have a windows setup where I can investigate myself, but maybe the naming convention of the library has been changed back to be consistent with earlier versions of proj and other OSes.

ocefpaf commented 4 years ago

The windows build errors must be related to this somehow: SciTools/cartopy:setup.py@master#L244-L247

I don't have a windows setup where I can investigate myself, but maybe the naming convention of the library has been changed back to be consistent with earlier versions of proj and other OSes.

Indeed. Upstream renamed that to be just proj.lib instead of proj_6_3.lib. I have a PR for that. Let me test the patch here first before I upstream it.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 4 years ago

This passes! xref.: https://github.com/SciTools/cartopy/pull/1463

dopplershift commented 4 years ago

An option would be to actually put this on a separate label and go ahead and build/release the beta package.

xylar commented 4 years ago

@dopplershift, that seems useful to me. @ocefpaf, how would I go about doing that?

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 4 years ago

@dopplershift, that seems useful to me. @ocefpaf, how would I go about doing that?

I changed the base from master to dev and updated the PR to reflect cfep-05. This should be OK to be merged to publish on the cartopy_dev label.

xylar commented 4 years ago

Looks good! @ocefpaf, since I'm not a maintainer of this feedstock, I think you'll need to merge.

xylar commented 4 years ago

@ocefpaf, I just wanted to point someone to the conda package for cartopy 0.18.0b1 and realized it never got created. If you look here: https://github.com/conda-forge/cartopy-feedstock/commits/dev CI never ran on the merge commit. Does the bot ignore the dev branch for some reason or did something else go wrong?

ocefpaf commented 4 years ago

CI never ran on the merge commit.

:-(

Does the bot ignore the dev branch for some reason or did something else go wrong?

It is not related to the bot. I'm investigating Azure logs to find out what happened.

ocefpaf commented 4 years ago

Looks like restarting the CIs did the trick:

https://anaconda.org/conda-forge/cartopy/files?channel=cartopy_dev

xylar commented 4 years ago

Great, glad you figured it out! Thanks!

conda-forge / cartopy-feedstock

build of 0.18.0b1 #76