search

conda-forge / casacore-feedstock

A conda-smithy repository for casacore.
BSD 3-Clause "New" or "Revised" License
0 stars 11 forks source link

build with ADIOS2 support #68

Closed r-xue closed 2 years ago

r-xue commented 2 years ago

Checklist

Sanity Checks:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw commented 2 years ago

Thanks for contributing this @r-xue! I've pushed some new commits that might hopefully get things working on osx-arm64 — on my local testing setup they work, but these things can be finicky.

The new MPI dependency is something to think about. I think that I would like to matrix the build to have a "nompi" variant lacking the ADIOS2 capability. If we can get the MPI version building, hopefully it should be straightforward to get nompi working again too.

r-xue commented 2 years ago

Thanks @pkgw for the fix!

After seeing the early failed builds, I actually tried build-locally.py on an M1-chip machine. Oddly, everything went fine (no FindMPI.cmake issue), which prompted me to think if this was related to the new macOS11 image (e.g. some extra bits inside). But I am glad this has been sorted out now.

I don't have anything to add. I did verify three things with the Linux version: 1) The current python-casacore package can take advantage of the adios2 data manager without any change, which is expected. 2) The table written by StandardStMan from python-casacore, works fine with casatools. 3) The four baked-in compressors (lossy: zfp; lossless: bzip2, xz, blosc), all work as intended (following the lead given by @rtobar in casacore/casacore/#1121).

Yes. I agree that nompi should stay or even by default. I don't know how to do it elegantly in the conda-forge setup at this moment. But this PR is in your hand now!

Thanks for your continued efforts in maintaining this repo.

pkgw commented 2 years ago

@r-xue Thanks for doing that validation work! And it looks like our new builds work! I think it should be straightforward to add a nompi version now.