Use qpOASES conda-forge package instead of the qpOASES vendored in casadi

conda-forge / casadi-feedstock

A conda-smithy repository for casadi.

BSD 3-Clause "New" or "Revised" License

8 stars 12 forks source link

Use qpOASES conda-forge package instead of the qpOASES vendored in casadi #76

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 1 year ago

Unfortunatly it appears that the copy of qpOASES contained in casadi is not compatible with upstream casadi due to sevderal casadi-specific changes that were done on it over the years: https://github.com/casadi/casadi/commits/12fa60f676716ae09aa2abe34c1c9b9cf426e68a/external_packages/qpOASES . One side, that means that ABI problems are certain if one links both casadi and qpoases, as casadi-qpoases uses the same names but a different ABI w.r.t. to actual qposes. A proper solution then is to use another namespace for the qpOASES in casadi, to avoid conflicts with ABI symbols.