conda-forge / cctbx-base-feedstock

A conda-smithy repository for cctbx-base.
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

remaining extra annlib dependency #12

Open Anthchirp opened 3 years ago

Anthchirp commented 3 years ago

I now have a preliminary dxtbx build that is based on the pre-compiled cctbx package: https://dev.azure.com/azure-dxtbx/dxtbx/_build/results?buildId=382&view=logs&j=027b87a4-6108-54a2-25c3-e49002181cdd

I noted that this still needs an extra annlib/annlib_adaptbx checkout, presumably because the prebuilt cctbx enables rstbx by default. A standard plain dxtbx build from scratch doesn't need rstbx, therefore doesn't configure it, and therefore works just fine without any annlib* stuff present: https://dev.azure.com/azure-dxtbx/dxtbx/_build/results?buildId=382&view=logs&j=bbb31556-568f-5bdc-5f88-8c2cd67ed7a6&t=398c8d41-a382-5623-6665-088a1dc79e38&l=33

Do you have any suggestions on this?

bkpoon commented 3 years ago

Right now, no, all the dependencies are added in case one of them is needed (e.g. a variable defined in one SConscript that is used in a different SConsript).

To build dxtbx, do you need anything in cctbx_project or any other repositories? If not, that can be a minimal test case for cleaning up the dependency tracking. I spent a little time on this, but I wanted to get the basic build/configuration out first. That's why the regular modules directory is needed right now.

Anthchirp commented 3 years ago

Source-wise a pure dxtbx build pulls in the cctbx_project, dxtbx, and cbflib repositories. Out of cctbx_project the only declared direct dependency is iotbx.

iotbx draws in transitive dependencies

And of course libtbx is implicitly required.

Again, this is not an urgent thing - I'm happy that we can build on top of cctbx. I'm hoping to enable pre-built cctbx testing for the dxtbx Azure builds this year, so we can get some experience and confidence in the process.