Add attrs and pip check

conda-forge / cdflib-feedstock

A conda-smithy repository for cdflib.

BSD 3-Clause "New" or "Revised" License

1 stars 5 forks source link

Add attrs and pip check #10

Closed smithara closed 2 years ago

smithara commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Should fix https://github.com/conda-forge/cdflib-feedstock/issues/9

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dstansby commented 2 years ago

Thanks for this - as far as I can tell attrs isn't actually used anywhere, so I've opened a PR to remove it as a dependency in https://github.com/MAVENSDC/cdflib/pull/169. I suggest I merge that in cdflib, then do a new release of cdflib, then do a new release on conda instead of merging this PR. Does that sound sensible?

smithara commented 2 years ago

Ah right okay! Thanks for the quick attention!