Add rdma-core(-devel) - Githubissues

conda-forge / cdt-builds

conda-forge cdt builds

BSD 3-Clause "New" or "Revised" License

4 stars 22 forks source link

Add rdma-core(-devel) #26

Closed jakirkham closed 4 years ago

jakirkham commented 4 years ago

Adds rdma-core and rdma-core-devel (looks like some other things get pulled in for the ride).

cc @mike-wendt

Checklist:

[ ] if you have added a CDT, it appears in the cdt_slugs.yaml file
[ ] if you have changed the CDT generator code (rpm.py), you have bumped the build number in conda_build_config.yaml and have remade all of the recipes via running python gen_cdt_recipes.py --force
[ ] if you have added a custom CDT recipe, you have added the name of the CDT with custom: true in the cdt_slugs.yaml file.
[ ] all CDT recipes have build number set by {{ cdt_build_number }} for old-style/legacy CDTs or {{ cdt_build_number|int + 1000 }} for new-style CDTs
[ ] if you see a warning about a CDT not having a license, you have added the license_file key in the cdt_slugs.yaml file with the path to the appropriate license in licenses/

jakirkham commented 4 years ago

Hope I did this right 😬 Just followed these instructions. Please let me know if I need to change anything @beckermr 🙂

beckermr commented 4 years ago

Some of the CDTs are missing license files.

jakirkham commented 4 years ago

AFAIK these packages were added on CentOS 7 and so don't exist on CentOS 6 (hence the skip).

The licenses (there are multiple) exist in /usr/share/licenses/rdma-core-22.4/. So would be installed in either case. I did try to use the license file syntax, but the script wasn't able to pick them up.

beckermr commented 4 years ago

AFAIK these packages were added on CentOS 7 and so don't exist on CentOS 6 (hence the skip).

We don't ever build centos6 on aarch64 and ppc64le, so they are already skipped.

The licenses (there are multiple) exist in /usr/share/licenses/rdma-core-22.4/. So would be installed in either case. I did try to use the license file syntax, but the script wasn't able to pick them up.

See the cdt_build.yaml file. You have to add the licenses to the repo in licenses and then put a path to them in that yaml file. Then rerun the recipe generating code.

jakirkham commented 4 years ago

Got it. Yeah happy to fix the archs.

Ah ok. That's what I was missing. Will do.

Sorry still learning how this script works 🙂

beckermr commented 4 years ago

Docs are not great. Sorry!

Suggestions and edits are def welcome!

jakirkham commented 4 years ago

Not at all. No need to be sorry. In fact thanks for putting this together 🙂 Just trying to catch up 😉

jakirkham commented 4 years ago

Thanks Matt! 😄

beckermr commented 4 years ago

Go ahead and merge when you are ready @jakirkham!

jakirkham commented 4 years ago

Seem to have missed generating a few CDTs. Having some trouble generating them with the script. Am trying to add them manually in PR ( https://github.com/conda-forge/cdt-builds/pull/28 ). Though would also welcome guidance on how to generate them automatically instead 🙂