conda-forge / cdt-builds

conda-forge cdt builds
BSD 3-Clause "New" or "Revised" License
4 stars 22 forks source link

ENH add systemd #36

Closed mbargull closed 4 years ago

mbargull commented 4 years ago

Please see the repo readme for directions on how to make PRs on this repo.

Checklist:

NOTE: If you make any changes to cd_slugs.yaml, you need to reun the generator code via python gen_cdt_recipes.py. Add the --fast option to make this go more quickly.

mbargull commented 4 years ago

Apart from the ones added to cdts_slugs.yaml, this also added kmod -- shall I add it to the YAML file, too?

beckermr commented 4 years ago

Apart from the ones added to cdts_slugs.yaml, this also added kmod -- shall I add it to the YAML file, too?

It is not formally required but it can be useful if you don't want to build this CDT on all platforms and centos versions.

mbargull commented 4 years ago

So kmod is only available on CentOS 7, so we won't have to skip for 6 :) (and having it for ARM/PPC is fine, of course). If you think it's good to add it to the list explicitly, then I'll happily added it; if not, also fine by me -- you're the expert here ^^.

Is there anything else I could've/should've done here? I never added a CDT recipe, hence asking. Essentially, I just added the skip/license fields/files and ran the Python script, but nothing else :O.

beckermr commented 4 years ago

The PR looks good and I cannot remember anything else that needs to be done. The code can be a bit finicky when making new CDTs. Sometimes you have to run it more than once. I'd say we merge and hopefully, the things you need get built. If you find they are missing, we can revisit.

mbargull commented 4 years ago

Alright, thanks for having taken a look at this (and that you've automated it to be used so conveniently)!

beckermr commented 4 years ago

Looks like the api key might be old. I will update it and rekick the builds.