Closed mbargull closed 4 years ago
Apart from the ones added to cdts_slugs.yaml
, this also added kmod
-- shall I add it to the YAML file, too?
Apart from the ones added to cdts_slugs.yaml, this also added kmod -- shall I add it to the YAML file, too?
It is not formally required but it can be useful if you don't want to build this CDT on all platforms and centos versions.
So kmod
is only available on CentOS 7, so we won't have to skip for 6 :) (and having it for ARM/PPC is fine, of course).
If you think it's good to add it to the list explicitly, then I'll happily added it; if not, also fine by me -- you're the expert here ^^.
Is there anything else I could've/should've done here? I never added a CDT recipe, hence asking. Essentially, I just added the skip/license fields/files and ran the Python script, but nothing else :O.
The PR looks good and I cannot remember anything else that needs to be done. The code can be a bit finicky when making new CDTs. Sometimes you have to run it more than once. I'd say we merge and hopefully, the things you need get built. If you find they are missing, we can revisit.
Alright, thanks for having taken a look at this (and that you've automated it to be used so conveniently)!
Looks like the api key might be old. I will update it and rekick the builds.
Please see the repo readme for directions on how to make PRs on this repo.
Checklist:
cdt_slugs.yaml
file and you have rerun the scriptpython gen_cdt_recipes.py
.rpm.py
), you have bumped the build number inconda_build_config.yaml
and have remade all of the recipes via runningpython gen_cdt_recipes.py --force
custom: true
in thecdt_slugs.yaml
file.{{ cdt_build_number }}
for old-style/legacy CDTs or{{ cdt_build_number|int + 1000 }}
for new-style CDTslicense_file
key in thecdt_slugs.yaml
file with the path to the appropriate license inlicenses/
NOTE: If you make any changes to
cd_slugs.yaml
, you need to reun the generator code viapython gen_cdt_recipes.py
. Add the--fast
option to make this go more quickly.