conda-forge / cdt-builds

conda-forge cdt builds
BSD 3-Clause "New" or "Revised" License
4 stars 22 forks source link

ENH add libglvnd-devel #45

Closed beckermr closed 3 years ago

beckermr commented 3 years ago

Please see the repo readme for directions on how to make PRs on this repo.

Checklist:

NOTE: If you make any changes to cd_slugs.yaml, you need to reun the generator code via python gen_cdt_recipes.py. Add the --fast option to make this go more quickly.

This PR replaces #45 and incorporates a fix so that old CDT recipes with url-only changes are not edited.

beckermr commented 3 years ago

@basnijholt can you please take a look here and see if the recipes look like they are what you need?

basnijholt commented 3 years ago

Yes, this is everything!

beckermr commented 3 years ago

Great! I am going to fix the license file stuff here. Can you comment on the extra build script bits? That doesn't appear to do anything...

basnijholt commented 3 years ago

It might be correct, I just copied those lines from another package. I wasn’t even sure myself what I was doing. 😅

beckermr commented 3 years ago

I see. We should try and find someone who knows this stuff to comment.

@conda-forge/core?

beckermr commented 3 years ago

I see a dep on mesa-libegl that looks odd given the other excluded dep.

beckermr commented 3 years ago

I didn't see any paths that looked like they need a symlink between mesa-libelg and libglvnd-gles, so I am going to go ahead and merge this. If we need to mark builds as broken later and try again, we can do that.

basnijholt commented 3 years ago

Amazing! Thanks a lot for the help 👍