Enable ceres & suitesparse for Windows.

conda-forge / ceres-solver-feedstock

A conda-smithy repository for ceres-solver.

BSD 3-Clause "New" or "Revised" License

2 stars 10 forks source link

Enable ceres & suitesparse for Windows. #10

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

hmm, it seems the suitesparse-feedstock needs a new build?

Package openblas conflicts for:
suitesparse=5.1 -> openblas[version='0.2.20|0.2.20.*|>=0.3.3,<0.3.4.0a0']
openblas=0.3.6
suitesparse=5.1 -> blas==1.1=openblas -> openblas
blas==1.1=openblas -> openblas

seanyen commented 4 years ago

Waiting for this. https://github.com/conda-forge/suitesparse-feedstock/pull/65

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

@jschueller Thanks for those tips! It seems now the conda is happy about the dependencies.

seanyen commented 4 years ago

@jschueller Btw, I am adding myself as a co-maintainer. Hope you don't mind. :)

seanyen commented 4 years ago

@jschueller Sorry to spam again. I think now the change is ready for merge. I am planning to add https://github.com/cartographer-project/cartographer feedstock and which depends on this change. Thanks!

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

seanyen commented 4 years ago

@jschueller Let me know any additional changes to make. Hope we can get this enabled for Windows build. Thanks.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

@jschueller The new suitesparse is merged and now on the conda-forge. And this is ready for review and merge. Thanks!

jschueller commented 4 years ago

you build with suitesparse 5.4 but for runtime 5.1 is still pulled, this seems inconsistent to me. maybe you'd want to pin suitesparse to 5.4 for the run requirements too, unless the pinning update gets merged first: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/564

seanyen commented 4 years ago

@jschueller Thanks for pointing out the version issue. I added the run_exports to the suitesparse, and by that way it should pull the version with it built against. https://github.com/conda-forge/suitesparse-feedstock/pull/66

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

@jschueller Finally the suitesparse pinning went through! And the CI looks green and consumes the latest 5.4 suitesparse for Windows.