Remove exact eigen requirement

conda-forge / ceres-solver-feedstock

A conda-smithy repository for ceres-solver.

BSD 3-Clause "New" or "Revised" License

2 stars 10 forks source link

Remove exact eigen requirement #23

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

See https://github.com/conda-forge/ceres-solver-feedstock/issues/19 for reasoning. Basically ceres requires that Eigen is unnecessarily the exact same version when compiling downstream pacakges. Fix https://github.com/conda-forge/ceres-solver-feedstock/issues/19

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

/cc @traversaro

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

jschueller commented 3 years ago

I'm not too sure on this: upstream added this for a reason, why not ask them if it can be removed ?

traversaro commented 3 years ago

I'm not too sure on this: upstream added this for a reason, why not ask them if it can be removed ?

This is a good idea, I can open an issue upstream later today (CEST).

Tobias-Fischer commented 3 years ago

Checking with upstream is probably a good idea. In this case, while we wait to hear back, shall we merge in #22 so we resolve issues downstream in the meantime?