conda-forge / clang-compiler-activation-feedstock

A conda-smithy repository for clang-compiler-activation.
BSD 3-Clause "New" or "Revised" License
2 stars 17 forks source link

fix: MACOSX_DEPLOYMENT_TARGET not protected in all uses #102

Closed henryiii closed 1 year ago

henryiii commented 1 year ago

Broke scikit-build, which requires that -DCMAKE_OSX_DEPLOYMENT_TARGET= is not empty.

Checklist

This was discovered in https://github.com/scikit-build/scikit-build/issues/911. I just copied the existing protection from a few lines above: https://github.com/conda-forge/clang-compiler-activation-feedstock/blob/d69b84b89b707760e3998968046cdd44cbc2e23b/recipe/activate-clang.sh#L101-L103

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 1 year ago

Thanks