Remove std=c++14 from flags

conda-forge / clang-compiler-activation-feedstock

A conda-smithy repository for clang-compiler-activation.

BSD 3-Clause "New" or "Revised" License

2 stars 17 forks source link

Remove std=c++14 from flags #75

Closed xhochy closed 2 years ago

xhochy commented 2 years ago

Fixes #17

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy commented 2 years ago

I would also

Backport this to 11.x
Build boost*=1.78 with this
Build a new abseil-cpp with this
Start the migration for both of them

katietz commented 2 years ago

Could you provide some details, why you consider to remove explicit std settings? As so we will use default behavior of clang-driver, which might get different for different versions. I agree that this way override of it via option gets more strict, but I might miss here something more interesting.

xhochy commented 2 years ago

This is based on @isuruf suggestion in https://github.com/conda-forge/clang-compiler-activation-feedstock/issues/17#issuecomment-831987409

xhochy commented 2 years ago

@isuruf Would you have time to look at this? I would be happy to bring this forward.

isuruf commented 2 years ago

@katietz, the issue with an explicit -std=c++14 is that it circumvents most build systems C++ setting. For some packages that need C++17, this forces them to use C++14. With clang 11, C++14 is the default, so this doesn't change anything for clang 11. However, it provides an easier way to use C++17 if a package needs it.

isuruf commented 2 years ago

@katietz, any thought on this?

isuruf commented 2 years ago

Ping @katietz

jakirkham commented 2 years ago

cc @anaconda-pkg-build

isuruf commented 2 years ago

Since I didn't hear from @katietz, going to assume this is okay.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing, but could not be merged (error=API error in POST to merge).

katietz commented 2 years ago

thanks, got clear to me why. Sorry that I was a bit off, but had to do the 3.10 built out on Anaconda's side... I am fine with the change

jakirkham commented 2 years ago

Thanks for taking another look Kai! 😄