search

conda-forge / clang-win-activation-feedstock

A conda-smithy repository for clang-win-activation.
BSD 3-Clause "New" or "Revised" License
1 stars 9 forks source link

Update header version for VS2019 #29

Open h-vetinari opened 1 year ago

h-vetinari commented 1 year ago

Seen in the logs on main:

+ [[ 14.29.30145 != 14.29.30133 ]]
If you have updated TOOLCHAIN_COMBINED but not the header version, 
it is likely that MSVC_HEADERS_VERSION should be 14.29.30145!

We may want to sharpen this to an error...? Or perhaps the check is too strict, and the header version in the artefact names doesn't have to match the path where the actual headers get installed...

PS. The unix builds don't depend on VS2019 (the toolchain), I just used this as a stand-in to distinguish the 14.29.x headers from 14.37.x.

h-vetinari commented 1 year ago

OK, so the check is wrong (at least in this case), and the header version as currently used is correct despite the divergence between artefact name and install path.