Add linux-aarch64 platform

conda-forge / cmdstan-feedstock

A conda-smithy repository for cmdstan.

BSD 3-Clause "New" or "Revised" License

1 stars 6 forks source link

Add linux-aarch64 platform #4

Closed WardBrian closed 3 years ago

WardBrian commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)

See comment below

[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This adds the aarch64 platform to the build. It uses a separate download of cmdstan packaged for this architecture.

More architectures will be coming: https://github.com/stan-dev/stanc3/pull/936

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [8, 10]

WardBrian commented 3 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

WardBrian commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

WardBrian commented 3 years ago

@conda-forge-admin, please rerender

WardBrian commented 3 years ago

Here's a discussion on gitter about the build numbers:

Brian Ward 14:33 If I'm adding a new build (adding linux-aarch64) but the existing recipes aren't changing at all, should I still increment the build number?

Matthew R. Becker 14:33 Not needed if the existing recipre builds are the same do double check this rerendering usually changes all of the CI files unless it was done very recently either way, our services will not upload duplicate builds

Brian Ward 14:34 The feedstock is very new, created last week

Matthew R. Becker 14:34 so even if you shipped different scripts with the same build number, users would not see them anyways got it sounds like you are fine to not increment the build number

Brian Ward 14:35 Looking at the file changes, nothing about the ci changed except for the arch specific Thanks!

Matthew R. Becker 14:35 ofc!

WardBrian commented 3 years ago

@maresb - if you could just take a brief look at this I'd appreciate it.

maresb commented 3 years ago

@WardBrian, looks great to me! But I'm not really qualified to review this though. If you truly want a second pair of eyes, then I'd ping isuruf and/or wolfv.

WardBrian commented 3 years ago

I was more just asking about obvious typos etc, I trust the CI/tests for the technical details of this sort of thing