ldallolio
commented
1 year ago Hi Kristoffer,
First of all, thank you for your contribution to the community! I am glad that someone is working for Code_Aster in the conda-forge environment :) I will try to look into your work as soon as possible and give you all the feedback that I can
As you already found out, I spent some time recently with the packaging of code_aster in conda-forge (I was asked by a research center to do so as they use it for they research project) and I could contribute some packages :
https://anaconda.org/conda-forge/code-aster (github https://github.com/conda-forge/code-aster-feedstock) https://anaconda.org/conda-forge/mfront https://anaconda.org/conda-forge/miss3d https://anaconda.org/conda-forge/libmed (as well as others like freefem, getfem, ...)
I have currently different targets :
- add newer versions of python interpreter --> segfault issue
- add newer versions of code_aster (15.x, 16.x) --> build issue detected by conda forge bots https://github.com/conda-forge/code-aster-feedstock/pulls
- add a windows (missing hdf5 fortran https://github.com/conda-forge/hdf5-feedstock/pull/203) / macos variant
- make all code_aster tests pass (for example this one https://github.com/conda-forge/code-aster-feedstock/blob/58e8378203915649ffe6928a4501966f027d13ee/recipe/meta.yaml#L85 )
- add a parallel (mpi) variant
I do not know yet your current knowledge in building "conda-forge packages" : I am more than willing to provide all the help that I can and save you as much time as possible :-) Conda-forge is in my opinion a step forward (both in complexity and final result) with respect to creating a simple "conda" package, we can talk about that if this interests you. If you are willing, I can add you among the package maintainers so that you can contribute directly to those projects.
First advice (you may already know that, in this case sorry for pointing out) : you should work on a fork on your personal repository https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests . Second advice : use mamba, not conda. Faster, much faster. Also much better dependency error reportings ;) Once installed, they are almost identical to use (you can simply use "mamba" instead of "conda"). But you are free to do as you prefer, of course. Third advice : build locally before committing, this will save you time, I can show you how if it helps you.
I have an hard time moving to a newer version of the python interpreter (I really need to have a >=3.10 version because of dependencies constraints) : it works perfectly using my local python but it doesn't with the one provided with conda forge (as I wrote, there are additional constraints in the forge to assure mutual compatibility among packages). I did isolate the issue in some python parts of Code_Aster which I cannot find in open source (I think that Matthieu coded those parts, I should ask him one of these days). I suspect that something is wrong with the code I had to put here in the package because I could not find anywhere else (and it is required ad build and at runtime): https://github.com/ldallolio/code-aster-feedstock/tree/main/recipe/contrib/asrun Code_Aster segfaults when building the command catalog, similar to this one : https://code-aster.org/forum2/viewtopic.php?id=1708
Please let me know I can help you, I will do my best :)
All the best, Luca
Il giorno mar 22 ago 2023 alle ore 08:08 Kristoffer Andersen < @.***> ha scritto:
Hey @ldallolio https://github.com/ldallolio,
I have done some work on making a conda package for code aster v16.4.2 (with help from Mathieu Courtois). You can check the progress here https://gitlab.com/codeaster/src/-/issues/1, The source code for all of the compilation work currently done on v16.4.2 can be found here https://github.com/Krande/condapackaging/tree/code-aster/16.4.2/src/code_aster
At the moment I've compiled and tested the v16.4.2 package for python 3.9, 3.10 and 3.11 and I am currently in the process of debugging the 5-10 % failing tests (150-200 of 2182 tests are failing due to various errors).
Once all (or a sufficient number of) the tests pass, my plan is to create a PR here and at the same time add the dependencies that currently aren't on conda-forge (such as mgis https://github.com/thelfer/MFrontGenericInterfaceSupport which I have discussed with Thomas Helfer).
I would really appreciate any thoughts you might have on things I should consider before making the PR, or if you have feedback/help you can provide on the current state of compiling code please let me know?
Best Regards Kristoffer
— Reply to this email directly, view it on GitHub https://github.com/conda-forge/code-aster-feedstock/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPAUDPXKWLOYNUNLQEXFXTXWREENANCNFSM6AAAAAA3ZMAFE4 . You are receiving this because you were mentioned.Message ID: @.***>
Krande
Hey @ldallolio,
I have done some work on making a conda package for code aster v16.4.2 (with help from Mathieu Courtois and by studying your work and the docker work by aether engineering). You can check the progress here https://gitlab.com/codeaster/src/-/issues/1, The source code for all of the compilation work currently done on v16.4.2 can be found here
At the moment I've compiled and tested the v16.4.2 package for python 3.9, 3.10 and 3.11 and I am currently in the process of debugging the 5-10 % failing tests (150-200 of 2182 tests are failing due to various errors).
Once all (or a sufficient number of) the tests pass, my plan is to create a PR here and at the same time add the dependencies that currently aren't on conda-forge (such as mgis which I have discussed with Thomas Helfer).
I would really appreciate any thoughts you might have on things I should consider before making the PR, or if you have feedback/help you can provide on the current state of compiling code please let me know?
Best Regards Kristoffer