Closed avsthiago closed 6 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hi @xhochy, @janjagusch, and @jtilly,
I'm addressing a build issue in our conda feedstock (link to build issue) due to CentOS 7's outdated GLIBC conflicting with Node 18 requirements.
Since code-server doesn't support cos7 anymore, would building the package on a different Linux distribution with a newer GLIBC be a feasible workaround in the conda-forge context? Any guidance or alternative suggestions would be greatly appreciated
+ code-server --help
node:internal/modules/cjs/loader:1340
return process.dlopen(module, path.toNamespacedPath(filename));
^
Error: /lib64/libc.so.6: version `GLIBC_2.25' not found (required by /home/conda/feedstock_root/build_artifacts/code-server_1701001419227/_h_env_placehold/share/code-server/node_modules/argon2/lib/binding/napi-v3/argon2.node)
at Module._extensions..node (node:internal/modules/cjs/loader:1340:18)
at Module.load (node:internal/modules/cjs/loader:1119:32)
at Module._load (node:internal/modules/cjs/loader:960:12)
at Module.require (node:internal/modules/cjs/loader:1143:19)
at require (node:internal/modules/cjs/helpers:119:18)
at Object.<anonymous> (/home/conda/feedstock_root/build_artifacts/code-server_1701001419227/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/share/code-server/node_modules/argon2/argon2.js:9:25)
at Module._compile (node:internal/modules/cjs/loader:1256:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
at Module.load (node:internal/modules/cjs/loader:1119:32)
at Module._load (node:internal/modules/cjs/loader:960:12) {
code: 'ERR_DLOPEN_FAILED'
At the moment, it's not possible.
@xhochy, what do you think about this solution? I kept the code-server --help
test for the osx
and aarch64
and reduced the test to only which code-server
when building the linux64
version.
My goal here is to unblock the osx
and aarch64
builds. I also expect the package to only fail on Linux only if the system doesn't have GLIBC >= 2.25.
@xhochy, could you please review this PR again when you have time?
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
meta.yaml
, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint .
from the recipe directory. Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin please rerender
@conda-forge-admin please rerender
@avsthiago Unfortunately, c_stdlib as sysroot was probably not it. After rerender, that was automatically fixed and logs changed to something else.
Perhaps the build container to Alma (within conda_build_config.yaml)?
Yeah, @ehfd, that didn't work. I'll give it another try with the Alma image.
@conda-forge-admin please rerender
Looks like the original solutions were right, except needing to rerender after putting it into conda_build_config.yaml.
@xhochy I tried to fix the build by only changing the c_stdlib_version
, but that didn't work. The only fix I found so far was to change the docker_image
.
Do you see any other option?
I guess changing docker_image for conda_build_config.yaml and rerendering is OK, if not changing the .scripts folder?
c_stdlib_version
is the way to go. What was the error?
Otherwise the version constraints will not be set correctly.
@xhochy
Compare the two. linux_64 still shows Error: /lib64/libc.so.6: version
GLIBC_2.25' not found` for testing. Build is successful, but cannot test.
@avsthiago @xhochy Perhaps require stdlib('c') with 2.28 constraint in the test environment as well? It can be that the test environment is capturing the container (outside) glibc environment. Otherwise, when sysroot is 2.28 the build container must change automatically to Alma 8.
We probably need the docker image and c_stdlib_version
at the same time. In future, setting the docker image should be obsolete, but until the new sysroot is fully rolled out, we will need to add that to conda_build_config.yaml
, too.
@xhochy Then everything is as it is now.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)