conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 53 forks source link

Remove GHC from Azure images #105

Closed jakirkham closed 4 years ago

jakirkham commented 4 years ago

Removes /opt/ghc from the Azure Linux image to free up some space needed by builds that need more room.

cc @isuruf @h-vetinari @pearu

Checklist

xref: https://github.com/conda-forge/omniscidb-feedstock/issues/5 xref: https://github.com/conda-forge/faiss-split-feedstock/pull/5

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pearu commented 4 years ago

@jakirkham thanks for tackling the shortage of disk space issue :)

jakirkham commented 4 years ago

Of course. Thanks for identify the fix! 😄

isuruf commented 4 years ago

This is run inside the docker container, so it's not going to do anything.

jakirkham commented 4 years ago

I followed your previous suggestion ( https://github.com/conda-forge/omniscidb-feedstock/issues/5#issuecomment-638479644 ). What are you suggesting we do instead?

pearu commented 4 years ago

Would rm -rf /opt/ghc be more effective when executing it from ${CONDA_PREFIX}/etc/conda/activate.d/conda-forge-ci-setup-activate.sh?

jakirkham commented 4 years ago

Guessing that will have the same issue. What if we move this to conda-smithy?

h-vetinari commented 4 years ago

Thanks @jakirkham @pearu for tackling this!

@isuruf: This is run inside the docker container, so it's not going to do anything.

We could mount /opt into the container when calling docker run, then the deletion will take effect on the FS as well. Or am I missing something?

xhochy commented 4 years ago

I would have expected to see this PR in smithy where we render the CI templates.

jakirkham commented 4 years ago

Submitted to conda-smithy in PR ( https://github.com/conda-forge/conda-smithy/pull/1345 ).